fix(p2p): request messages for an explicit block and round - #1444
Draft
oXtxNt9U wants to merge 3 commits into
Draft
fix(p2p): request messages for an explicit block and round#1444oXtxNt9U wants to merge 3 commits into
oXtxNt9U wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1444 +/- ##
===========================================
- Coverage 78.03% 77.70% -0.34%
===========================================
Files 952 963 +11
Lines 16300 17002 +702
Branches 2337 2461 +124
===========================================
+ Hits 12720 13211 +491
- Misses 3575 3784 +209
- Partials 5 7 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oXtxNt9U
marked this pull request as ready for review
August 10, 2026 04:33
oXtxNt9U
force-pushed
the
feat/p2p/get-messages-round
branch
2 times, most recently
from
August 25, 2026 05:38
baaa3d9 to
68302e1
Compare
oXtxNt9U
force-pushed
the
feat/p2p/get-messages-round
branch
from
August 25, 2026 05:39
68302e1 to
b65766f
Compare
oXtxNt9U
marked this pull request as draft
August 26, 2026 10:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetMessagesrequests now carry an explicit (blockNumber, round, bitmaps) query instead of the responder guessing from the request headers. The responder serves exactly the queried round or nothing.Checklist